feat(editor): add paintSelectionAboveText to control selection paint … - #2750
Open
iznurrehmankhan wants to merge 1 commit into
Open
feat(editor): add paintSelectionAboveText to control selection paint …#2750iznurrehmankhan wants to merge 1 commit into
iznurrehmankhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a configuration option to control whether the selection highlight is painted above or below the text.
Background
PR #429 changed the paint order so the selection is rendered above the text. This fixed cases where the selection was hidden by text line background colors.
However, rendering the selection above the text can make the selected text difficult to read in some applications.
This PR keeps the current behavior as the default for backward compatibility while allowing applications to render the selection behind the text when desired.
Testing